Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gn] Update to current version #24142

Closed
wants to merge 3 commits into from
Closed

[gn] Update to current version #24142

wants to merge 3 commits into from

Conversation

bold84
Copy link
Contributor

@bold84 bold84 commented Apr 14, 2022 •
edited
Loading

Describe the pull request

While trying to update the Skia port, I found that it doesn't build with vcpkg's version of GN. It seems to be too old.

This change may require updates to ports that use gn.

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Doesn't look like it does anything

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@bold84 bold84 changed the title Update gn 2 [gn] Update to current version Apr 14, 2022
@bold84 bold84 mentioned this pull request Apr 14, 2022
Merged
@bold84
Copy link
Contributor Author

bold84 commented Apr 14, 2022

So, how am I supposed to do this?
Updating the Skia port to a newer version requires updating gn. But it seems that the old gn isn't compatible with the new Skia gn files.
Just one PR for all of it?

@JonLiu1993 JonLiu1993 self-assigned this Apr 15, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 15, 2022
@JonLiu1993
Copy link
Member

JonLiu1993 commented Apr 15, 2022 •
edited
Loading

So, how am I supposed to do this? Updating the Skia port to a newer version requires updating gn. But it seems that the old gn isn't compatible with the new Skia gn files. Just one PR for all of it?

@bold84, thanks for the pr, you need to submit the pr together to update them, before your pr a user submitted pr update gn and skia but not done #18194

@bold84
Copy link
Contributor Author

bold84 commented Apr 15, 2022

@JonLiu1993 Than you for your response.
I’ll have a look at the PR you mentioned. Next time I’ll search for unfinished PRs.

@bold84
Copy link
Contributor Author

bold84 commented Apr 15, 2022

Closing this PR, will continue updating in this PR: #24066

@bold84 bold84 closed this Apr 15, 2022
@bold84 bold84 deleted the update_gn_2 branch April 17, 2022 23:19
@bold84 bold84 restored the update_gn_2 branch April 17, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bold84 @JonLiu1993